`TabNav` component incorrect focus order

[GlebIrovich]

Description

TabNav component has incorrect focus order.

Current behaviour:
When "tabbing" latest selected tab is focused

Expecte:
Active tab if focused.
Accessible example

Screen.Recording.2023-02-03.at.14.53.35.mov

Steps to reproduce

1. Go to docs
2. Tab to TabNav, use arrow keys to select a tab which is not currently active
3. Tab back and forth

Version

v35.18.0

Browser

Chrome

[rezrah]

Likely due to tabIndex being set to -1. Unsure on reason for this, but it could be intentional. If we're happy to remove this however, it should resolve the issue.

[kendallgassner]

@inkblotty should we move this the audit-issues repo?

[inkblotty]

@kendallgassner - Yes that’s a good idea. We can add the right labels from there.

…

On Fri, Feb 3, 2023 at 9:59 AM Kendall Gassner ***@***.***> wrote: @inkblotty <https://github.com/inkblotty> should we move this the audit-issues repo? — Reply to this email directly, view it on GitHub <#2855 (comment)> or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADMMIMZKQKKDQKJ2PW2S4ZLWVUTO5BFKMF2HI4TJMJ2XIZLTSWBKK5TBNR2WLKJYGM4TMMZYGEYTLJDOMFWWLKLIMFZV63DBMJSWZAVFOZQWY5LFVIZTINRXGM3TMNJRGWSG4YLNMWUWQYLTL5WGCYTFNSBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLLDTOVRGUZLDORPXI6LQMWWES43TOVSUG33NNVSW45FGORXXA2LDOOKIFJDUPFYGLKTSMVYG643JORXXE6NFOZQWY5LFVEYTEMJYGE2DEMJQQKSHI6LQMWSWYYLCMVWKK5TBNR2WLKJYGM4TMMZYGEYTLAVEOR4XAZNFNRQWEZLMUV3GC3DVMWVDGNBWG4ZTONRVGE2YFJDUPFYGLJLJONZXKZNFOZQWY5LFVIYTKNRZHA4DKNRUGOTXI4TJM5TWK4VGMNZGKYLUMU> . You are receiving this email because you were mentioned. Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub> .

[lesliecdubs]

Discussed with the PRC crew and decided we should use custom strategy of focus zone here. https://github.com/primer/behaviors/blob/main/docs/focus-zone.md#:~:text=from%20the%20first-,focusInStrategy,-%22first%22%20%E2%94%82%20%22closest%22%20%E2%94%82%20%22previous

[kendallgassner]

I cannot move this issue 🤔 to our audits repo. I wonder if its an org issue since this is org='primer'?

[inkblotty]

I do think it's an org issue Kendall. Are there already issues in accessibility-audits that call out this concern? Or should we make a corresponding issue there?

[kendallgassner]

I can make a corresponding ticket 😄

[joshblack]

Closed as part of: #2845

This should be included in the latest release! Let me know if you're still seeing this issue 😄