Skip to content

Use correct colors for StateLabel #3038

Description

@camertron

Description

One of our users recently reached out via Zendesk asking about the color of the "Open" issue/PR status label while using the light and dark colorblind themes. It turns out orange is the right color based on this discussion and this PR. @simurai also further documented the decision in this ADR.

Both PVC and PCSS show the correct color for the colorblind theme, but PRC does not:

image

Steps to reproduce

The problem can be seen in this story: https://primer.style/react/storybook/?path=/story/components-statelabel--playground&args=status:pullOpened&globals=colorScheme:dark_colorblind

Version

v35.21

Browser

Chrome

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingreact

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions