Focus not appearing on non-standard dialog button (re-opened after revert)

[ctmayn]

Description

Focus does not appear at all on Primary and Danger buttons in a Dialog Footer

Steps to reproduce

1. Go to https://primer.style/react/storybook/?path=/story/components-dialog--stress-test
2. Open the Dialog
3. Use tab to move through the footer buttons
4. Notice that once you get to the danger and primary buttons, focus is no longer visible

Version

v35.22

Browser

Chrome

[langermank]

This should be a quick fix. The Dialog component is using the deprecated Button component, which doesn't have the new focus styles. Here's the source code for Dialog. Updating it to use the new Button component will solve it.

[tallys]

@langermank assigning your way, let me know if you can take a look since it looks like a quick fix.

[broccolinisoup]

Just following up after watching the primer planning recording, we have a PR created for this from a contributor. I reviewed the PR and commented on it. I'll keep an eye on it to see if they follow up with the request change 👀

[siddharthkp]

Thank you @mperrotti!

This was reopened because of #3527