Styling differs betwen IconButton and Button with variant="invisible"

[mattcosta7]

Description

IconButton with vairiant=invisible has different foreground color and a noticeable disabled state
Button with variant=inivisble has the same foreground color as variant=outline and no disabled state

Steps to reproduce

Use an IconButton and a Button with variant=invisible side by side

Version

latest

Browser

No response

Update from @siddharthkp: Adding screenshots

default state:

hover state:

[lesliecdubs]

@tallys do you want to see if a designer is available to take a look at this?

[tallys]

@mperrotti do you have availability to take this on?

[langermank]

@mperrotti we may need to open this up to a larger discussion about the invisible variant, but the idea is that the foreground color is only link blue for Button if there are no visuals present as demonstrated here. And IconButton is never link blue. There was recent discussion in Slack about this too.

outline variant is being deprecated, and then there's the link variant which is also confusing. Long long ago I proposed making the API overly verbose for buttons styled as links to better differentiate between the invisible variant and a link variant.

Anyways, should we open a discussion? Still worth fixing the disabled state mentioned in this issue.

[mperrotti]

Yes @langermank - fully agree that we should open a discussion. Would you like to start the discussion? or should I?

[mperrotti]

Button with variant=inivisble has the same foreground color as variant=outline and no disabled state

@mattcosta7 - I see a disabled state on when testing <Button variant="invisible" disabled>Test</Button>. The only inconsistency I'm seeing is the foreground color.

Here's the PR: #3368

[mattcosta7]

Button with variant=inivisble has the same foreground color as variant=outline and no disabled state

@mattcosta7 - I see a disabled state on when testing <Button variant="invisible" disabled>Test</Button>. The only inconsistency I'm seeing is the foreground color.

Here's the PR: #3368

That sounds about right