Release Tracking

[github-actions]

This is a scheduled issue for tracking the release between Monday 22nd and Friday 26th

Last week	Value
Issue	Release Tracking
Conductor	colebemis
Release Pull Request	Link
Integration tests	Link

Timeline

• Monday 22nd
• Tuesday 23rd
• Wednesday 24th
• Thursday 25th
• Friday 26th

Checklist

• Checks have passed on the integration Pull Request downstream
• Release tracking Pull Request has been merged
• Stable release available on npm
• Downstream repos have been updated to latest

Notes

[siddharthkp]

Checks have passed on the integration Pull Request downstream

They have not 😢 Follow conversation on slack

[joshblack]

Copying over notes from Release PR

---

Release handover for @joshblack

Current status: Multiple versions of primer/react installed in integration PR

• Integration PR: https://github.com/github/github/pull/274199

Feel free to skip to Update 3

---

Update 1:

There were some build errors in dotcom related to missing dependencies: https://github.com/github/github/pull/274199#issuecomment-1561268455

ERROR in ./node_modules/@primer/react/lib-esm/utils/theme2.js 2:0-40
Module not found: Error: Can't resolve 'lodash.isempty' in '/workspace/github/node_modules/@primer/react/lib-esm/utils'

ERROR in ./node_modules/@primer/react/lib-esm/utils/theme2.js 3:0-41
Module not found: Error: Can't resolve 'lodash.isobject' in '/workspace/github/node_modules/@primer/react/lib-esm/utils'

ERROR in ./node_modules/@primer/react/lib-esm/utils/theme2.js 4:0-35
Module not found: Error: Can't resolve 'chroma-js' in '/workspace/github/node_modules/@primer/react/lib-esm/utils'

These should be fixed by 2 PRs merged last week

• Remove chroma-js dependency #3325
• Move theme dependencies on lodash from devDependencies to dependencies #3332

Hoooowever, we are still seeing one of the errors in the build after these PRs:

ERROR in ./node_modules/@primer/react/lib-esm/utils/theme2.js 4:0-35
Module not found: Error: Can't resolve 'chroma-js' in '/workspace/github/node_modules/@primer/react/lib-esm/utils'
resolve 'chroma-js' in '/workspace/github/node_modules/@primer/react/lib-esm/utils'

The error is in the same file lib-esm/utils/theme2.js, however this file, does not have chroma-js anymore, which is very confusing 🤔

---

Update 2:

I verified that the dotcom/integration PR is installing the latest rc version from release tracking PR.

However, running ./bin/precompile-assets on codespaces does return the error!

So, there is definitely a file which has chroma-js somewhere...

---

Update 3:

Found the problem, like we've seen before there are two versions of @primer/react:

1. root/npm-workspaces/primer/node_modules/@primer/react/package.json#L3: "35.26.0-rc.2c2eef7a" (latest version)

2. root/node_modules/@primer/react/package.json#L3: "35.26.0-rc.e00166d8" (outdated version, this one is being used)

Do we already know why this happens and how to fix it?