Release Tracking

[github-actions]

This is a scheduled issue for tracking the release between Monday 10th and Friday 14th

Last week	Value
Issue	Release Tracking
Conductor	joshblack
Release Pull Request	Link
Integration tests	Link

Timeline

• Monday, July 10th
• Tuesday, July 11th
• Wednesday, July 12th
• Thursday, July 13th
• Friday, July 14th

Checklist

• Checks have passed on the integration Pull Request downstream
• Release tracking Pull Request has been merged
• Stable release available on npm
• Downstream repos have been updated to latest

Notes

[siddharthkp]

Hello!

Latest status: Need to triage 3 2 1 failing checks on integration PR: https://github.com/github/github/pull/280392.

• There is one test failing now related to service owners, which isn't related to primer/react, so we should be good!

Fun updates:

• The first 2 attempts of running checks on the integration PR failed to install node_modules at the right spot. gh/gh#280050 and gh/gh#280092
  • Thank you @dgreif for adding a script to hoist node_module gh/gh#278495 ❤️
  • Now we have an integration PR that runs the checks with the right primer/react version from node_modules: https://github.com/github/github/pull/280392
  • The nightly workflow does install node_modules incorrectly, so need to run script/npm-dependencies-changed after each workflow run
• There are failing checks on integration PR. Have not triaged them yet.
  • Had to revert 1 PR Revert "[Dialog] Replace deprecated Button for current one" #3527
  • There is a type error in ui/packages/github-avatar that fails tsc in memex, not sure why is this only showing up in the integration PR. It seeeems like that this particular test was getting a cached result until now??! Update: i've fixed the type error 🤷‍♂️
  • only one error to go: snek-e2e, trying to understand if it's because of the release or not
• There is a node_modules inside primer/react now (not on main) because we use a different version of primer/react-octicons (^19.3.0) than what's in the primer workspace (18.3.0)
  • need to check what are the breaking changes before updating primer workspace

Other odd things:

• Sometimes the checks simply don't run on the integration PR when it's created from a workflow. (see slack discussion. Pushing a commit from codespaces helps them gets started.
  • Update: see Dusty's comment below
• Need to see if we run into licenses issues related to changesets/cli or is it fixed after Add --no-save flag to release workflow .github#17.
  • Update: we do not 🎉

[dgreif]

Regarding the actions not running on the integration PR, it's likely caused by this issue. This is a major downside to pushing commits with the GITHUB_TOKEN, and something I'd love to see us fix for all GitHub users. Wouldn't hurt to weigh in on that issue that it's impacting the Primer team 😄.

The main workaround is to use a PAT to clone instead of GITHUB_TOKEN. Then your commits are linked to a real account (whatever account the PAT is for) instead of "GitHub Actions". Major downsides are that you need some of bot account to create the PAT, and the PAT will likely have an expiration date.

Other solution is to push a commit like you have been doing. This is a manual intervention and not obvious. You could also leverage the new Tidy UI action in dotcom to push a commit for you, but that will only take effect if the code you push to your PR is lacking all the correct changes (e.g. node_modules are not hoisted or license files did not get updated).

[siddharthkp]

Thanks @dgreif, that is very useful!

[joshblack]

@dgreif would it be possible to use a GitHub App as the account to push commits and trigger the workflows? 👀

[siddharthkp]

Update: There is only test failing now, which is related to service owners, so we should be good to publish a new version of primer/react!

[dgreif]

@dgreif would it be possible to use a GitHub App as the account to push commits and trigger the workflows? 👀

I'm honestly not sure. I think so, and I vaguely recall PRC using the Changesets app to push changes during a release, which I believe triggered Actions without any problems