Warning: React does not recognize the `leadingIcon` prop on a DOM element.
If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `leadingicon` instead. If you accidentally passed it from a parent component, remove it from the DOM element.
at a
at onClick (/workspace/github/node_modules/react-router-dom/index.tsx:473:7)
Because the fix is straightforward, I'd like for us to fix it instead of revert it. (hopefully before something else gets merged and breaks main of course 💀 )
This is a scheduled issue for tracking the release between Monday 11th and Friday 15th
Timeline
Tuesday, Sept 12
Wednesday, , Sept 13
Thursday, Sept 14
Integration PR isn't green yet, there seems to be a React prop that is passed through to the underlying element
It is likely coming from one of these 2 files:
Both have a
Button as={Link} leadingIcon={icon}/>where the Link points to @github-ui/react-core/linkThis is related to this tiny change: https://github.com/primer/react/pull/3715/files#diff-d63160e1a0bc6e1b413bf57891f51fc3a16158f9bbe8dba87aacf395f2644ef2L14-L15 from feat(Button): add support for leadingVisual and trailingVisual #3715
Because the fix is straightforward, I'd like for us to fix it instead of revert it. (hopefully before something else gets merged and breaks main of course 💀 )
Friday, Sept 15
Monday - Tuesday, Sept 18 - 19
Wednesday, Sept 20
Checklist
Notes