Skip to content

Unexpected border in SelectPanel footer #5735

Description

@lumaxis

Description

We noticed an unexpected border in the footer of SelectPanel which causes odd UI which especially noticeable in dark mode. An example is the GitHub issue label picker:

Screenshot of the GitHub issue labels picker in dark mode

I did some spelunking and suspect that this might be the culprit: https://github.com/primer/react/blame/65a197b01fa50d0c4a58bd5eff46dc7f2e6d6dfc/packages/react/src/SelectPanel/SelectPanel.tsx#L524-L525

Steps to reproduce

  1. Go to any issue on e.g. https://github.com/primer/react/issues
  2. Open the label picker
  3. Observe a very prominent border between the labels list and the "Edit labels" footer
Screenshot of the GitHub issue labels picker in light mode

Version

v37.13.0

Browser

Edge

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingreact

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions