Skip to content

KeybindingHint only considers MacOS and Windows when displaying key names #7756

Description

@iansan5653

When used as a modifier in KeybindingHint, the Meta key is correctly displayed as Win (Windows key) on Windows and (Command key) on MacOS. However, on all other devices, it is displayed as Win even though the Windows key does not exist on other devices.

Current behavior

Meta

  • MacOS: /Command (matching the logic from github/hotkey, and based on the fact that the iPad Magic Keyboard has a Command key)
  • All other operating systems: Win/Windows

Alt

  • MacOS: /Option
  • All other operating systems: Alt

Mod (dynamic modifier)

  • MacOS: /Command
  • All other operating systems: /Control

Expected behavior

Meta

  • MacOS and iOS: /Command (matching the logic from github/hotkey, and based on the fact that the iPad Magic Keyboard has a Command key)
  • Windows: Win/Windows
  • All other operating systems: Meta (since the key doesn't map to anything consistent on Linux/Android)

Alt

  • MacOS and iOS: /Option
  • All other operating systems: Alt

Mod (dynamic modifier)

  • MacOS and iOS: /Command
  • All other operating systems: /Control

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions