Skip to content

Dropdown start hidden - #1171

Merged
dgreif merged 3 commits into
mainfrom
dropdown-start-hidden
Apr 20, 2021
Merged

Dropdown start hidden#1171
dgreif merged 3 commits into
mainfrom
dropdown-start-hidden

Conversation

@dgreif

@dgreifdgreif commented Apr 16, 2021

Copy link
Copy Markdown
Contributor

The Overlay currently shows immediately when the DropdownMenu/ActionMenu opens, and then it is positioned. This change will keep them in a visibility: hidden state until after the position is calculated and applied. This prevents the element from popping into place visibly, and ensure the animations run properly. Also unblocks #1165, which needs the changes made in useAnchoredPosition.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

@dgreif
dgreif requested a review from T-HugsApril 16, 2021 22:42
@changeset-bot

changeset-botBot commented Apr 16, 2021•
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 9a44800

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel

vercelBot commented Apr 16, 2021•
edited
Loading

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-components/21K3SRZu2efPDqwVo8GsXGNxDaGa
✅ Preview: https://primer-components-git-dropdown-start-hidden-primer.vercel.app

dgreif
dgreif commented Apr 16, 2021
View reviewed changes
Comment threadsrc/hooks/useCombinedRefs.ts
Comment on lines +30 to +34
return () => {
// ensure the refs get updated on unmount
// eslint-disable-next-line react-hooks/exhaustive-deps
setRefs(combinedRef.current)
}

@dgreifdgreifApr 16, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ensures that the callback refs get called with null if their container component is removed. Without this, useAnchoredPosition wouldn't know that the floating element disappeared, and thus not set the position to undefined ever after the first time a menu is opened.

@dgreifdgreif mentioned this pull request Apr 19, 2021
Merged
6 tasks
T-Hugs
T-Hugs reviewed Apr 20, 2021
View reviewed changes
Comment threadsrc/hooks/useCombinedRefs.ts Outdated
T-Hugs
T-Hugs approved these changes Apr 20, 2021
View reviewed changes

@T-HugsT-Hugs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@dgreif
dgreifforce-pushed the dropdown-start-hidden branch from 6c4f8fe to 9a44800CompareApril 20, 2021 15:10
@dgreif
dgreif enabled auto-merge April 20, 2021 15:11
@dgreif
dgreif merged commit 06e138e into mainApr 20, 2021
@dgreif
dgreif deleted the dropdown-start-hidden branch April 20, 2021 15:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@T-HugsT-HugsT-Hugs approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dgreif@T-Hugs