Skip to content

Extract AnchoredOverlay from DropdownMenu and ActionMenu - #1179

Merged
dgreif merged 7 commits into
mainfrom
anchored-overlay
Apr 23, 2021
Merged

Extract AnchoredOverlay from DropdownMenu and ActionMenu#1179
dgreif merged 7 commits into
mainfrom
anchored-overlay

Conversation

@dgreif

Copy link
Copy Markdown
Contributor

DropdownMenu and ActionMenu shared a lot of similar code related to positioning the overlay and key bindings on the anchor/overlay. The shared pieces are now extracted into a new AnchoredOverlay component, which is the equivalent of a Popover from previous planning. This component is currently internal-only (not exported in index.ts) to allow time for changes to occur before fully documenting and exporting it.

Closes#1064

Screenshots

Please provide before/after screenshots for any visual changes

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

@changeset-bot

changeset-botBot commented Apr 21, 2021

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 74d7c0b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel

vercelBot commented Apr 21, 2021

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-components/5ASXriQK3ShAm4NEjFhEQg1FVg5a
✅ Preview: https://primer-components-git-anchored-overlay-primer.vercel.app

Comment threadsrc/AnchoredOverlay/AnchoredOverlay.tsx Outdated
Comment threadsrc/AnchoredOverlay/AnchoredOverlay.tsx Outdated
Comment threadsrc/AnchoredOverlay/AnchoredOverlay.tsx Outdated

@T-HugsT-Hugs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🚌

Comment threadsrc/AnchoredOverlay/AnchoredOverlay.tsx Outdated

@colebemiscolebemis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Nice work!

@dgreif
dgreif enabled auto-merge (squash) April 23, 2021 20:22
@dgreif
dgreif disabled auto-merge April 23, 2021 20:22
@dgreif
dgreif merged commit f506dcf into mainApr 23, 2021
@dgreif
dgreif deleted the anchored-overlay branch April 23, 2021 20:22
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Popover

3 participants

@dgreif@T-Hugs@colebemis