Skip to content

Removes irregular styling on Timeline - #1424

Merged
colebemis merged 2 commits into
mainfrom
jfuchs/timeline-idiosyncracy
Sep 15, 2021
Merged

Removes irregular styling on Timeline#1424
colebemis merged 2 commits into
mainfrom
jfuchs/timeline-idiosyncracy

Conversation

@jfuchs

Copy link
Copy Markdown
Contributor

While figuring out some TS issues I ran into this one place where we have styling defined via the CSS prop.

Screenshots

Please provide before/after screenshots for any visual changes

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@jfuchs
jfuchs requested a review from a teamSeptember 14, 2021 19:16
@changeset-bot

changeset-botBot commented Sep 14, 2021

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 6fba113

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@primer/componentsPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actionsBot commented Sep 14, 2021

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
dist/browser.esm.js48.74 KB (-0.21% 🔽)
dist/browser.umd.js49.03 KB (-0.21% 🔽)

@colebemis
colebemis enabled auto-merge (squash) September 15, 2021 20:38
@colebemis
colebemis merged commit 7cf8d8b into mainSep 15, 2021
@colebemis
colebemis deleted the jfuchs/timeline-idiosyncracy branch September 15, 2021 20:41
@primer-cssprimer-css mentioned this pull request Sep 15, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jfuchs@colebemis