Uh oh!
There was an error while loading. Please reload this page.
Add focus and hover colors to all themes in Item using functional variables - #1486
Conversation
🦋 Changeset detectedLatest commit: e1208d4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
pksjce
commented
Sep 30, 2021
Notes -
|
colebemis
commented
Sep 30, 2021
Looks like
Let's loop in @tallys and @auareyou because I think this issue is going to require more design work than I initially thought. |
mperrotti
commented
Oct 27, 2021
@pksjce - should we modify this PR now that primer/primitives#256 has merged? |
Uh oh!
There was an error while loading. Please reload this page.
| data-id={id} | ||
| onKeyPress={keyPressHandler} | ||
| onClick={clickHandler} | ||
| hoverBackground={disabled ? 'inherit' : hoverBackground} |

Before this PR, hardcoded RGB colors were being used for the hover and focus states. I changed them to use the functional color system as described in #1480
Screenshots
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.