Uh oh!
There was an error while loading. Please reload this page.
ActionList: Use icon instead of input for multiple selection - #1591
Closed
siddharthkp wants to merge 119 commits into
Closed
ActionList: Use icon instead of input for multiple selection#1591siddharthkp wants to merge 119 commits into
siddharthkp wants to merge 119 commits into
Conversation
This reverts commit 4d1cc22.
Co-authored-by: Cole Bemis <colebemis@github.com>
🦋 Changeset detectedLatest commit: fb551cb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
siddharthkp
commented
Nov 11, 2021
MemberAuthor
Replaced by #1601 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change base after #1517 is merged
Part of https://github.com/github/primer/issues/447
Fixes half of https://github.com/github/primer/issues/228
Nested interactive controls are not announced by screen readers, the accessibility advice here is not use interactive elements for presentation.
input type="checkbox"with svg from primer/cssScreenshots
look pretty:
Accessibility violations:
Before:
After:
Please provide before/after screenshots for any visual changes
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.