Uh oh!
There was an error while loading. Please reload this page.
Input field components - text, checkbox, radio - #1611
Conversation
🦋 Changeset detectedLatest commit: ad9e954 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Note: I intentionally excluded this animation for the ChoiceFieldset because it has nowhere to animate in from
size-limit report 📦
|
Co-authored-by: Rez <rezrah@github.com>
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…o mp/form-field-component
| <!-- | ||
| TODO: add `validationStatus` examples when we have the validation styling done | ||
| --> |
There was a problem hiding this comment.
I guess we could get rid of it
Uh oh!
There was an error while loading. Please reload this page.
| import {ChoiceInputField, Checkbox, Radio} from '@primer/react' | ||
| import {MarkGithubIcon} from '@primer/octicons-react' | ||
| import {ComponentChecklist} from '../src/component-checklist' | ||
| import {PropsTable} from '../src/props-table' |
There was a problem hiding this comment.
Some of these imports may not be needed anymore
There was a problem hiding this comment.
I'll see what I can get rid of. When I excluded the PropsTable import, it caused a deployment error in Vercel.
Co-authored-by: Rez <rezrah@github.com>
| ) | ||
| const results = await axe(container) | ||
| expect(results).toHaveNoViolations() | ||
| cleanup() |
There was a problem hiding this comment.
Might be worth running cleanup and jest.clearAllMocks(); on an afterEach block at the top of the test suite, as you're using spy a fair bit here
This component renders input along with its label, validation content, and hint content. It will correctly associate labels and other related content with the input.
Screenshots
Value input
Toggle (radio/checkbox) input
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.
ClosesPrimer issue #480