Uh oh!
There was an error while loading. Please reload this page.
Add side effects false to package.json - #1719
Conversation
|
| '@primer/react': patch | ||
| --- | ||
| adds sideEffects false back to package.json |
There was a problem hiding this comment.
I don't think we need a changeset on this PR because it patches unreleased changes
There was a problem hiding this comment.
removed it, but can't add the label
This reverts commit 7be6bb6.
* add side effects false to package.json * changeset * Revert "changeset" This reverts commit 7be6bb6.
Describe your changes here.
Fixes a bundler related bug introduced via #1700 where the sideEffects declaration was removed from package.json, potentially causing bundlers to not properly treeshake unused modules.
#1332 introduced this fix initially, but had to declare specific files as containing sideEffects, due to their implementation. When removing these files to a dependency, this should have been left in
Screenshots
Please provide before/after screenshots for any visual changes
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.