Skip to content

Export FocusKeys enum - #1724

Merged
colebemis merged 5 commits into
mainfrom
export-behaviors
Dec 15, 2021
Merged

Export FocusKeys enum#1724
colebemis merged 5 commits into
mainfrom
export-behaviors

Conversation

@dgreif

@dgreifdgreif commented Dec 13, 2021

Copy link
Copy Markdown
Contributor

In #1700, we started using the extracted @primer/behaviors component. From a down-stream perspective, this change removed access to the FocusKeys enum, which now lives in @primer/behaviors. To make the transition easier, we can simply re-export that enum from @primer/react.

@dgreif
dgreif requested review from a team and colebemisDecember 13, 2021 20:53
@changeset-bot

changeset-botBot commented Dec 13, 2021•
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 47d7887

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actionsBot commented Dec 13, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
dist/browser.esm.js57.5 KB (0%)
dist/browser.umd.js57.8 KB (0%)

@dgreifdgreif added the skip changeset This change does not need a changelog label Dec 14, 2021
colebemis
colebemis reviewed Dec 15, 2021
View reviewed changes
Comment threadsrc/hooks/useFocusZone.ts
colebemis
colebemis reviewed Dec 15, 2021
View reviewed changes
Comment threadsrc/hooks/useFocusZone.ts Outdated
colebemis
colebemis reviewed Dec 15, 2021
View reviewed changes
Comment threadsrc/hooks/useFocusZone.ts Outdated
@colebemis
colebemis enabled auto-merge (squash) December 15, 2021 20:01
@colebemis
colebemis merged commit a030ab3 into mainDec 15, 2021
@colebemis
colebemis deleted the export-behaviors branch December 15, 2021 20:05
@colebemiscolebemis mentioned this pull request Dec 15, 2021
Merged
pksjce pushed a commit that referenced this pull request Dec 20, 2021
@dgreif@colebemis@pksjce
Export FocusKeys enum (#1724)
32d44fd
* Export FocusKeys enum
* Export Direction
* Update src/hooks/useFocusZone.ts
* Update src/hooks/useFocusZone.ts
Co-authored-by: Cole Bemis <colebemis@github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@colebemiscolebemiscolebemis left review comments
@pksjcepksjcepksjce approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip changesetThis change does not need a changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dgreif@pksjce@colebemis