Skip to content

CI: disable visual testing - #1786

Closed
siddharthkp wants to merge 4 commits into
mainfrom
siddharth/disable-visual-testing
Closed

CI: disable visual testing#1786
siddharthkp wants to merge 4 commits into
mainfrom
siddharth/disable-visual-testing

Conversation

@siddharthkp

@siddharthkpsiddharthkp commented Jan 11, 2022•
edited
Loading

Copy link
Copy Markdown
Member

Remove visual testing action till our limit is reset more context on slack.

To enable it again, we can revert this PR :)

@changeset-bot

changeset-botBot commented Jan 11, 2022•
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 8d3c033

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@siddharthkp
siddharthkp temporarily deployed to visual-testing January 11, 2022 13:28 Inactive
@siddharthkpsiddharthkp added react skip changeset This change does not need a changelog labels Jan 11, 2022
@github-actions

github-actionsBot commented Jan 11, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
dist/browser.esm.js61.25 KB (0%)
dist/browser.umd.js61.63 KB (0%)

@siddharthkpsiddharthkp self-assigned this Jan 11, 2022
@siddharthkp
siddharthkp marked this pull request as ready for review January 11, 2022 13:35
@siddharthkp
siddharthkp requested a review from a teamJanuary 11, 2022 13:35
@siddharthkpsiddharthkp changed the title Skip visual testingCI: skip visual testingJan 11, 2022
@siddharthkpsiddharthkp changed the title CI: skip visual testingCI: disable visual testingJan 11, 2022
@rezrah

rezrah commented Jan 13, 2022

Copy link
Copy Markdown
Contributor

To make it easier to renable this without a code change in future, can we keep the workflow in repo and disable it via click-ops instead? https://docs.github.com/en/actions/managing-workflow-runs/disabling-and-enabling-a-workflow

@siddharthkp

siddharthkp commented Jan 14, 2022•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

That's cool too! We don't need this PR :)

Note for future: Enable this action from this link - https://github.com/primer/react/actions/workflows/visual_testing.yml

@jsorefjsoref mentioned this pull request Feb 27, 2022
Closed
@joshblack
joshblack deleted the siddharth/disable-visual-testing branch January 19, 2023 16:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mperrottimperrottiAwaiting requested review from mperrotti
@rezrahrezrahAwaiting requested review from rezrah

Assignees

@siddharthkpsiddharthkp

Labels

reactskip changesetThis change does not need a changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@siddharthkp@rezrah