Uh oh!
There was an error while loading. Please reload this page.
Remove transitive dependency type augmentations from build output - #1855
Merged
Conversation
🦋 Changeset detectedLatest commit: d47ca2c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
jclemforce-pushed
the
remove-storybook-types
branch
from
February 10, 2022 16:43
8f949b7 to
879be67Comparejclem
marked this pull request as draft
February 10, 2022 17:09
jclemforce-pushed
the
remove-storybook-types
branch
3 times, most recently
from
February 10, 2022 18:03
a647712 to
bd6ace0Comparejclem
marked this pull request as ready for review
February 10, 2022 18:07
6 tasks
jclem
marked this pull request as draft
February 10, 2022 19:47
* Add annotation step to test_types workflow * Remove branch restriction from `pull_request` event * Make tsconfig.build.json fail consumer test * Add always() to if clause in test_types workflow * Use clearer failed() instead of always() * Remove brackets from workflow if * s/status/conclusion * s/failed/failure * Add longer annotation * Format workflow echo * Attempt to use cat for multi-line annotation * Rename to consumer test * Add issue context links * Nicer links in consumer test readme * Revert "Make tsconfig.build.json fail consumer test" This reverts commit f6a3678. * Add consumer-test to eslintrc ignore
jclemforce-pushed
the
remove-storybook-types
branch
from
February 10, 2022 20:00
ecf3e46 to
a09d63dComparejclem
marked this pull request as ready for review
February 10, 2022 20:00
jclem
requested review from
colebemis and jfuchs
and removed request for
rezrahFebruary 10, 2022 20:00
colebemis
approved these changes
Feb 10, 2022
colebemis
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the fix and for adding tests! ✨
jclem
enabled auto-merge (squash)
February 10, 2022 22:23
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes tests and test utilities from our TypeScript builds. Some of them import Storybook types, and doing so forces Storybook types and its dependencies' React interface augmentations like those added by @emotion/core into our types output.
This also adds a new workflow (I didn't integrate it into CI while we test it out), that ensures that a consumer of Primer React can pass TypeScript compilation with
"skipLibChecks": false.