Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 677
Deprecate ActionMenu v1 & Promote drafts/ActionMenu v2 #1895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
e0349543d6718224bc583aab2fc8eea615e5d618c205818fac78fa1596085ccf7fbac9d642d32File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| --- | ||
| '@primer/react': major | ||
| --- | ||
| ### ActionMenu | ||
| ActionMenu now ships a composable API that utilises ActionList | ||
| See full list of props and examples: https://primer.style/react/ActionMenu | ||
| Main changes: | ||
| 1. Instead of using `items` prop, use `ActionList` inside `ActionMenu` | ||
| 2. Instead of using `anchorContent` on `ActionMenu`, use `ActionMenu.Button` with `children` | ||
| 3. Instead of using `onAction` prop on `ActionMenu`, use `onSelect` prop on `ActionList.Item` | ||
| 4. Instead of using `groupMetadata` on `ActionMenu`, use `ActionList.Group` | ||
| 5. Instead of `overlayProps` on `ActionMenu`, use `ActionMenu.Overlay` | ||
| <table> | ||
| <tr> | ||
| <th> Before </th> <th> After </th> | ||
| </tr> | ||
| <tr> | ||
| <td valign="top"> | ||
| ```jsx | ||
| <ActionMenu | ||
| anchorContent="Menu" | ||
| onAction={fn} | ||
| items={[ | ||
| {text: 'New file'}, | ||
| {text: 'Copy link'}, | ||
| {text: 'Edit file'}, | ||
| ActionMenu.Divider, | ||
| {text: 'Delete file', variant: 'danger'} | ||
| ]} | ||
| overlayProps={{width: 'small'}} | ||
| /> | ||
| ``` | ||
| </td> | ||
| <td valign="top"> | ||
| ```jsx | ||
| <ActionMenu> | ||
| <ActionMenu.Button>Menu</ActionMenu.Button> | ||
| <ActionMenu.Overlay width="small"> | ||
| <ActionList> | ||
| <ActionList.Item onSelect={fn}>New file</ActionList.Item> | ||
| <ActionList.Item>Copy link</ActionList.Item> | ||
| <ActionList.Item>Edit file</ActionList.Item> | ||
| <ActionList.Divider /> | ||
| <ActionList.Item variant="danger">Delete file</ActionList.Item> | ||
| </ActionList> | ||
| </ActionMenu.Overlay> | ||
| </ActionMenu> | ||
| ``` | ||
| </td> | ||
| </tr> | ||
| </table> | ||
| To continue to use the deprecated API for now, change the import path to `@primer/react/deprecated`: | ||
| ```js | ||
| import {ActionMenu} from '@primer/react/deprecated' | ||
| ``` | ||
Contributor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add the codemod bit here too? | ||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.