Uh oh!
There was an error while loading. Please reload this page.
Add overlay props to Autocomplete.Overlay - #1967
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 63272bb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
pksjceforce-pushed
the
pk/autocomplete-overlay-bug
branch
from
March 16, 2022 09:35
c408554 to
042d372CompareContributor
size-limit report 📦
|
| if (autocompleteContext === null) { | ||
| throw new Error('AutocompleteContext returned null values') | ||
| } | ||
| const overlayProps = {...oldOverlayProps, ...newOverlayProps} |
Member
There was a problem hiding this comment.
backwards compatibility! love to see it!
siddharthkp
approved these changes
Mar 16, 2022
pksjceforce-pushed
the
pk/autocomplete-overlay-bug
branch
from
March 17, 2022 04:10
042d372 to
8584557Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes here.
Add overlay props to Autocomplete.Overlay
Closes#1951
Merge checklist