Uh oh!
There was an error while loading. Please reload this page.
Update primer/behaviors for esm compatibility - #2002
Merged
Conversation
🦋 Changeset detectedLatest commit: cbc5bed The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
pksjce
commented
Mar 29, 2022
Contributor
Would you think its useful to add a similar |
pksjce
approved these changes
Mar 29, 2022
dgreif
commented
Mar 29, 2022
ContributorAuthor
I think it has |
pksjce
commented
Mar 30, 2022
Contributor
|
dgreif
enabled auto-merge (squash)
March 31, 2022 15:02
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In v
1.1.1, @primer/behaviors adds better support of imports with ESM. This resolves issues for projects attempting to import @primer/react in environments that support ESM, but do not recognize themoduleexport type. It also allows us to remove the override that caused Jest to tranform the behaviors files before using them.Merge checklist