Uh oh!
There was an error while loading. Please reload this page.
docs: fix typos - #2040
Merged
Merged
Conversation
|
siddharthkp
approved these changes
Jun 20, 2022
siddharthkp
left a comment
Member
There was a problem hiding this comment.
Thanks for taking the time :)
Contributor
@PrinceSumberia 👋 if you're able to please fix the merge conflicts, we can get this preview deployed and merged. Please reach out to us if you have any questions. thanks. |
* namespace underline classes? * snippity snaps * Create quick-toys-fly.md
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* fixes disabled option colors for all browsers (Firefox had the most issues) * fixes custom arrow color for disabled state and Windows high contrast mode, and hacks around Firefox quirks * updates SelectInput stories to use FormControl * makes cursor behavior consistent for inputs * removes redundant ARIA attributes from <select> * updates tests and snapshots * adds changeset * fixes media query for forced colors (high contrast mode) * hacks around Firefox Windows high-contrast mode quirk * addresses a11y feedback * fixes linting
* updates focus styles that do not match the Primer CSS implementation * updates ThemeSwitcher to render ActionMenu instead of DropdownMenu * explicitly sets outline-offset in global focus styles instead of adding a new style that 'beats' the default 2px * update snapshots * fixes cross-browser issues for global focus styles * fixes unintentional laggy focus style update on SubNav * updates focus styles for UnderlineNav * DRY button focus styles * updates snapshots * adds changeset * fixes type error * revert themePreval snapshot update
* Add breaking story * Add memex story * use behaviors deploy preview * add tooltip triangle * update snapshot * add label tooltips for story * update @primer/behaviors to latest * lint: remove unused import * Refactor Tooltip * Use Tooltip in IconButton * Add triangle styles for all directions * Add docs * Added delay * change ReactElement to ReactNode * keep ReactElement * Add tests! * compatible types :) * Fix docs * update snapshots * update behaviors to next minor * update snapshots * Fix IconButton duplicate label * missed a spot! * Fix Button story with tooltip * Apply suggestions from code review Co-authored-by: Cole Bemis <colebemis@github.com> * fix alignment with span Co-authored-by: Cole Bemis <colebemis@github.com>
* Create NavList component * Implement NavList subcomponents * Reset font weight of trailing visual * Export NavList from drafts * Update NavList docs * Update NavList.mdx * Add children to props type * Add NavList tests * Create breezy-cooks-destroy.md * Pass props to underlying nav element * Show divider between groups * Update snapshot
* disable theme decorator for themeprovider story * remove incorrect effect * Create wicked-boats-allow.md Co-authored-by: Mike Perrotti <mperrotti@github.com>
* Move theme decorator into helper util * fix height * is addons import the problem? * does this work better for consumer-tests? * yep, deep import doesn't work either * add option to disable theme decorator on a story level Co-authored-by: Mike Perrotti <mperrotti@github.com>
* Create improved-tooltip.md * Create iconbutton-default-tooltip.md * typo lol
* wip subnav * Add active prop to ActionList.Item * Handle nested current item * Add simple storybook story * Update snapshot * Stub tests * Use NavList in PageLayout story * Add test case todo * Fix sx typescript error * Add NavList.Item test * Add subnav tests * Add support for as="button" to ActionList.Item * Add nested subnav test * Update docs * Use spacing primitive * Reset marginY for safari * Document active prop * Create strong-nails-sip.md * Update snapshots
primer#2063) * Update issue templates for this repo to include redirects to pattern proposal and request issues * Delete component proposal issue template * Update pattern discussion URL
* Make ButtonGroup display inline-flex * Create documentation page for ButtonGroup * Update Button docs * Create six-mirrors-call.md * Update tests * Update stories * Update six-mirrors-call.md
* adjust width based on padding * update snapshost
* adds color-scheme style so inputs pick up UA color scheme styles * crops toggle switch knob's shadow inside the toggle switch boundaries * does not stretch FormControl input child to fill parent width unless 'block' prop is passed, and passes missing TextInputWrapper props in the Select component * adds changeset * rm duplicate prop
* Add support for `sx` prop to NavList components * Default sx to empty object * Create happy-brooms-swim.md * Update snapshot
* updates Link href paths that link to React components * adds changeset
* Fix IconButton for ActionMenu * Add test case
* Add as prop to NavList.Item * Add test case for react router link with subnav * Use DOM APIs to determine if subnav contains current item * Update snapshots * Remove "not implemented" warnings * Create dry-feet-attack.md * Fix merge issues * Update snapshot
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Draft SplitPageLayout API docs * Update docs/content/SplitPageLayout.mdx Co-authored-by: Vinicius Depizzol <vdepizzol@gmail.com> * Update docs/content/SplitPageLayout.mdx * visible -> hidden prop Co-authored-by: Vinicius Depizzol <vdepizzol@gmail.com>
* Build theme-preval to esm * Use default export for theme-preval * Create sweet-elephants-end.md * Update theme-preval snapshot
* updates checkbox props tables, storybook stories, and storybook controls * updates Radio props table, Storybook stories, and Storybook controls * updates FormControl Storybook stories, and Storybook controls * updates TextInput and TextInputWithWrapper props tables, Storybook stories, and Storybook controls * updates Select stories * fixes more issues with Select stories and prop docs * updates Textarea prop tables, Storybook stories, and Storybook controls * updates CheckboxGroup and RadioGroup Storybook stories, and Storybook controls * updates Autocomplete Storybook stories, and Storybook controls * fixes 'size' control in TextInput stories * fixes a11y issues with Autocomplete examples * updates input stories to use the FormControl component and controls, and updates sidebar to reflect that relationship * updates tests * adds changeset * fix linting issue * updates after merging from main * excludes story-helpers.tsx from build * fixes regression in CheckboxGroup and RadioGroup fixture stories
* update version of primer primitives * update preval stamp * changeset * update snapshot
* implements keyboard navigation strategy for the SegmentedControl suggested by the a11y team, and warns component users if the control does not have a label * adds changeset * crappy fix for bug where useFocusZone breaks after selecting a button * corrects typo in test name * consolidates button focus test, and adds comment to focusInStrategy test * remove getNextFocusable by tweaking focusInStrategy Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…losed` colour (primer#2171) * Updated StateLabel * Add changeset * Update test * Update the test suites
* fixes broken focus outline on the Select component * fixes linting issue * adds changeset
* renders a tooltip for icon-only segmented control buttons * implements responsive variant prop * adds tests * minor story tweaks * refactor useMatchMedia * adds useMatchMedia tests, fixes useMatchMedia bugs, updates SegmentedControl tests * removes aria attributes from Storybook controls * rm irrelevant 'TODO' comments * adds changeset * adds helpful comments * fixes button font-size in Safari * updates snapshots * addresses PR feedback * Update docs/content/SegmentedControl.mdx Co-authored-by: Cole Bemis <colebemis@github.com> * Update docs/content/SegmentedControl.mdx Co-authored-by: Cole Bemis <colebemis@github.com> * Update .changeset/pretty-students-judge.md Co-authored-by: Josep Martins <jsp.mrtns@gmail.com> * bumps @primer/primitives to version with segmented control variables * corrects storybook knobs to match current API * rm 'wide' key from 'variant' prop in props table * fix bad merge in SegmentedControl * adds more context to a11y issues with the tooltip implementation * adds changeset Co-authored-by: Cole Bemis <colebemis@github.com> Co-authored-by: Josep Martins <jsp.mrtns@gmail.com>
* bumps @primer/primitives and uses SegmentedControl component tokens * revert comment change in SegmentedControlIconButton * adds changeset * update themePreval snap with primitives@7.9.0
* Implement responsive hidden prop * Write tests for useResponsiveValue * Document hidden prop * Update viewport range variables * Add hidden prop to header/footer/content * Update PageLayout tests * Create empty-garlics-clean.md * Fix lint errors
* update button to respect polymorphic as prop * update docs * update docs * fix doc * changeset * fix by removing sc as propr types * Add back link buttons stories using basic button Co-authored-by: Pavithra Kodmad <pksjce@github.com>
…er#2172) * Add storybook play function for autocomplete * Add github workflow * Must run on pull-request and push to main * Package.lock revert * update workflow * configure static directories * Build storybooks correctly * A more complete autocomplete test * Fix up packge lock? * Fix up packge lock? * Add some documentation * Fix up autocomplete tests by adding data-testid
* run react 18 types codemod * run prettier * changeset
* Upgrade `userEvent` to v14 * Fix Autocomplete tests Co-authored-by: Cole Bemis <colebemis@github.com>
* Deprecate dividerWhenNarrow in favor of responsive values * Update PageLayout docs * Create spotty-parents-cheat.md * Update spotty-parents-cheat.md * Update snapshots
Adding another use-case in the NavList's NextJS example
* Update position prop API * Update snapshots * Update docs * Create fair-tips-travel.md
* Revert "Revert "ActionMenu: Remove focus trap (primer#1984)" (primer#2023)" This reverts commit 866abc0. * prevent scroll when moving from anchor to menu * Add shortcut example from memex * progress! * make refs required * onclick should not interfere with keyboard * default to first item if anchor is not used * use userEvent instead of fireEvent for test to get full event * remedy merge * ignore containerRef for initial focus * update changeset to include initial focus on click * migrate to user-event@14 Co-authored-by: Cole Bemis <colebemis@github.com>
… is a dangerous one (primer#2185) * allow configuration of the initial focus in a confirmation dialog * changeset * explicitly set the autoFocus when danger to cancel * intermediate value Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes typos
Merge checklist