Skip to content

Create contributing-docs/debt.md - #2071

Closed
siddharthkp wants to merge 2 commits into
mainfrom
siddharthkp/debt-md
Closed

Create contributing-docs/debt.md#2071
siddharthkp wants to merge 2 commits into
mainfrom
siddharthkp/debt-md

Conversation

@siddharthkp

@siddharthkpsiddharthkp commented May 12, 2022

Copy link
Copy Markdown
Member

wip

  • create-slots needs a double render which would create UI jank with server side rendering as visuals & descriptions slots are not filled until hydration on client
  • primitives are resolved to hex values instead of css variables which creates flash of incorrect theme
  • styled-components + styled-system performance adds up over time as components build up

@changeset-bot

changeset-botBot commented May 12, 2022

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: f8d7389

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@siddharthkpsiddharthkp changed the title Create debt.mdCreate contributing-docs/debt.mdMay 12, 2022
@github-actions

github-actionsBot commented May 12, 2022

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
dist/browser.esm.js65.79 KB (0%)
dist/browser.umd.js66.08 KB (0%)

@siddharthkpsiddharthkp added the skip changeset This change does not need a changelog label May 12, 2022
@siddharthkpsiddharthkp self-assigned this May 12, 2022
@siddharthkp
siddharthkp temporarily deployed to github-pages May 12, 2022 10:19 Inactive
@github-actions

Copy link
Copy Markdown
Contributor

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

@joshblack
joshblack deleted the siddharthkp/debt-md branch January 19, 2023 16:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changesetThis change does not need a changelogStale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@siddharthkp