Skip to content

Docs: Prevent deployments when there are unreleased changes#2091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
siddharthkp merged 1 commit into from
May 23, 2022
Merged

Docs: Prevent deployments when there are unreleased changes #2091

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/deploy_production.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,7 +35,7 @@ jobs:
deploy:
name: Production
needs: [guard]
#if: ${{ needs.guard.outputs.should_deploy == true }}
if: ${{ needs.guard.outputs.should_deploy == 'true' }}

@siddharthkpsiddharthkpMay 23, 2022•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@colebemis Turns out output is set as a string instead of boolean :)

uses: primer/.github/.github/workflows/deploy.yml@main
with:
node_version: 16
Expand Down