Skip to content

Set aria-multiselectable in SelectPanel#2095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hectahertz merged 4 commits into from
May 25, 2022
Merged

Set aria-multiselectable in SelectPanel #2095

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
761c7bd
Set aria-multiselectable on SelectPanel
hectahertz May 24, 2022
a22c17e
Add changeset
hectahertz May 24, 2022
5891c3d
Merge branch 'main' into hectahertz/selectpanel-aria-multiselectable
hectahertz May 24, 2022
8aee281
Merge branch 'main' into hectahertz/selectpanel-aria-multiselectable
hectahertz May 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/slimy-rabbits-try.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@primer/react': patch
---

Communicate the SelectPanel multi-select capability to assistive technologies.
3 changes: 2 additions & 1 deletion src/SelectPanel/SelectPanel.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -158,8 +158,9 @@ export function SelectPanel({
onFilterChange={onFilterChange}
{...listProps}
role="listbox"
items={itemsToRender}
aria-multiselectable={isMultiSelectVariant(selected) ? 'true' : 'false'}
selectionVariant={isMultiSelectVariant(selected) ? 'multiple' : 'single'}
items={itemsToRender}
textInputProps={extendedTextInputProps}
inputRef={inputRef}
// inheriting height and maxHeight ensures that the FilteredActionList is never taller
Expand Down