Uh oh!
There was an error while loading. Please reload this page.
Fix slots infinite rendering when no context prop is provided - #2219
Merged
Conversation
🦋 Changeset detectedLatest commit: 9914932 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
iansan5653
commented
Aug 5, 2022
ContributorAuthor
Just realized I totally missed the existing slots test file. Going to put this back in draft for now until I fix that 😅 |
iansan5653
marked this pull request as draft
August 5, 2022 19:06
iansan5653
marked this pull request as ready for review
August 5, 2022 19:09
iansan5653
commented
Aug 5, 2022
ContributorAuthor
Fixed - deleted my new test and updated the existing ones to not always define the |
iansan5653
enabled auto-merge (squash)
August 11, 2022 16:16
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First, updated the slots tests to that the
contextprop is not always defined. This caused the tests to fail due to infinite rendering, as expected from #2187.Then, fixed the bug by defaulting
contextto a statically referenced frozen object instead of a new object on every render. This fixes#2187 and makes the tests pass ✅.Merge checklist
[ ] Added/updated documentation