Skip to content

Updates SegmentedControl to Alpha status - #2228

Merged
colebemis merged 10 commits into
mainfrom
mp/segmented-conrol-draft-to-alpha
Aug 18, 2022
Merged

Updates SegmentedControl to Alpha status#2228
colebemis merged 10 commits into
mainfrom
mp/segmented-conrol-draft-to-alpha

Conversation

@mperrotti

@mperrottimperrotti commented Aug 12, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@mperrotti
mperrotti requested review from a team and siddharthkpAugust 12, 2022 17:40
@changeset-bot

changeset-botBot commented Aug 12, 2022•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c33301f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@primer/reactMinor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actionsBot commented Aug 12, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
dist/browser.esm.js75.76 KB (+2.02% 🔺)
dist/browser.umd.js76.36 KB (+2.06% 🔺)

@mperrotti
mperrotti temporarily deployed to github-pages August 12, 2022 17:51 Inactive
@mperrotti
mperrotti temporarily deployed to github-pages August 12, 2022 17:53 Inactive
@mperrotti
mperrotti temporarily deployed to github-pages August 15, 2022 15:51 Inactive
@mperrotti
mperrotti temporarily deployed to github-pages August 15, 2022 15:52 Inactive
mperrotti
mperrotti commented Aug 15, 2022
View reviewed changes
Comment threaddocs/content/SegmentedControl.mdx
title: SegmentedControl
status: Draft
description: Use a segmented control to let users select an option from a short list and immediately apply the selection
status: Alpha

@mperrottimperrottiAug 15, 2022

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The component lifecycle label doesn't appear to be updating. Is there something else I need to do to get this showing "Alpha" instead of "Drafts"?

Screen Shot 2022-08-15 at 11 56 22 AM

@siddharthkpsiddharthkpAug 15, 2022•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be related to preview deployment build because I see your changes on my machine 🤔

@siddharthkpsiddharthkpAug 16, 2022•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deployment is fixed now, turns out it was my fault ✨ 🙃

colebemis
colebemis approved these changes Aug 16, 2022
View reviewed changes

@colebemiscolebemis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

colebemis
colebemis reviewed Aug 16, 2022
View reviewed changes
Comment threaddocs/content/SegmentedControl.mdx Outdated
@siddharthkp
siddharthkp temporarily deployed to github-pages August 16, 2022 09:41 Inactive
siddharthkp
siddharthkp approved these changes Aug 16, 2022
View reviewed changes

@siddharthkpsiddharthkp left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it's just me again, but navigation through arrow keys introduced in #2145 doesn't work 🤔

Perfect otherwise, approving in advance.

Screen recording:

segmented-control-keyboard-interaction.mov

@mperrotti

mperrotti commented Aug 17, 2022

Copy link
Copy Markdown
ContributorAuthor

@siddharthkp - it's working as expected. We removed that functionality in #2220

@mperrotti
mperrotti temporarily deployed to github-pages August 17, 2022 15:55 Inactive
@mperrotti
mperrotti temporarily deployed to github-pages August 17, 2022 23:30 Inactive
@mperrotti
mperrotti temporarily deployed to github-pages August 18, 2022 18:31 Inactive
@colebemis
colebemis merged commit bf99db9 into mainAug 18, 2022
@colebemis
colebemis deleted the mp/segmented-conrol-draft-to-alpha branch August 18, 2022 20:44
@primer-cssprimer-css mentioned this pull request Aug 18, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@siddharthkpsiddharthkpsiddharthkp approved these changes
+1 more reviewer
@colebemiscolebemiscolebemis approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mperrotti@siddharthkp@colebemis