Skip to content

Implement SplitPageLayout#2239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colebemis merged 12 commits into from
Aug 18, 2022
Merged

Implement SplitPageLayout #2239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a1bd783
Create SplitPageLayout component
colebemis Aug 17, 2022
ede3897
Merge remote-tracking branch 'origin/main' into splitpagelayout-impl
colebemis Aug 17, 2022
5e0e169
Fix hidden prop in PageLayout.Content
colebemis Aug 17, 2022
fc84da5
Update how SplitPageLayout extends PageLayout
colebemis Aug 17, 2022
61325a9
Update PageLayout and SplitPageLayout docs
colebemis Aug 17, 2022
032ae6a
Add SplitPageLayout stories
colebemis Aug 17, 2022
c380284
Update default value of content width
colebemis Aug 17, 2022
fe111db
Update imports
colebemis Aug 17, 2022
4f32586
Create four-jeans-travel.md
colebemis Aug 17, 2022
ac5d626
Add SplitPageLayout tests
colebemis Aug 17, 2022
00a07f9
Merge branch 'splitpagelayout-impl' of github.com:primer/react into s…
colebemis Aug 17, 2022
6375a93
Add condensed paddding example
colebemis Aug 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/four-jeans-travel.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

Add draft `SplitPageLayout` component
12 changes: 6 additions & 6 deletions docs/content/PageLayout.mdx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@ componentId: page_layout
status: Alpha
# description: TODO
source: https://github.com/primer/react/tree/main/src/PageLayout
storybook: https://primer.style/react/storybook?path=/story/layout-pagelayout--playground
storybook: https://primer.style/react/storybook?path=/story/layout-pagelayout--default
---

```js
Expand DownExpand Up@@ -215,7 +215,7 @@ See [storybook](https://primer.style/react/storybook?path=/story/layout-pagelayo
type={`| 'none'
| 'condensed'
| 'normal'`}
defaultValue="'normal'"
defaultValue="'none'"
description="The amount of padding inside the header."
/>
<PropsTableRow
Expand DownExpand Up@@ -277,7 +277,7 @@ See [storybook](https://primer.style/react/storybook?path=/story/layout-pagelayo
type={`| 'none'
| 'condensed'
| 'normal'`}
defaultValue="'normal'"
defaultValue="'none'"
description="The amount of padding inside the content."
/>
<PropsTableRow
Expand DownExpand Up@@ -312,7 +312,7 @@ See [storybook](https://primer.style/react/storybook?path=/story/layout-pagelayo
| 'start'
| 'end'
}`}
defaultValue="'start'"
defaultValue="'end'"
/>
<PropsTableRow
name="positionWhenNarrow"
Expand DownExpand Up@@ -342,7 +342,7 @@ See [storybook](https://primer.style/react/storybook?path=/story/layout-pagelayo
type={`| 'none'
| 'condensed'
| 'normal'`}
defaultValue="'normal'"
defaultValue="'none'"
description="The amount of padding inside the pane."
/>
<PropsTableRow
Expand DownExpand Up@@ -395,7 +395,7 @@ See [storybook](https://primer.style/react/storybook?path=/story/layout-pagelayo
type={`| 'none'
| 'condensed'
| 'normal'`}
defaultValue="'normal'"
defaultValue="'none'"
description="The amount of padding inside the footer."
/>
<PropsTableRow
Expand Down
Loading