Uh oh!
There was an error while loading. Please reload this page.
feat(PageLayout): add support for labeling through aria-label, aria-labelledby - #2294
Merged
Conversation
🦋 Changeset detectedLatest commit: 8a10923 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
joshblack
marked this pull request as ready for review
August 31, 2022 15:52
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Cole Bemis <colebemis@github.com>
hectahertz
approved these changes
Sep 2, 2022
hectahertz
left a comment
Contributor
There was a problem hiding this comment.
Great work @joshblack! 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closeshttps://github.com/github/primer/issues/1254
This PR adds in support for labelling
PageLayout.Header,PageLayout.Content, andPageLayout.Footerthrough eitheraria-labeloraria-labelledby.It also provides additional information in the
PageLayoutdocs for these landmark roles through a new Accessibility section.