Uh oh!
There was an error while loading. Please reload this page.
TreeView: Add nesting indicator lines - #2350
Merged
Merged
Conversation
Co-authored-by: Eric Bailey <ericwbailey@users.noreply.github.com>
🦋 Changeset detectedLatest commit: 61a2d83 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
colebemis
commented
Sep 20, 2022
ContributorAuthor
This PR is ready for review but let's not merge until we merge #2331 |
| // fade in when the user mouses over the entire component, | ||
| // or when there's focus inside the component. This makes | ||
| // sure the component remains simple when not in use. | ||
| '@media (hover: hover)': { |
joshblack
approved these changes
Sep 20, 2022
joshblack
left a comment
Member
There was a problem hiding this comment.
So cool, love the usage of grid 🔥
The setup with @media (hover: hover) is slick, love how it easily it falls back on iOS Safari and enhances on Chrome/FF/Safari
mperrotti
approved these changes
Sep 20, 2022
Comment on lines
+428
to
+432
| // On devices with :hover support, the nesting indicator lines | ||
| // fade in when the user mouses over the entire component, | ||
| // or when there's focus inside the component. This makes | ||
| // sure the component remains simple when not in use. | ||
| '@media (hover: hover)': { |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds lines to indicate the depth of items in a TreeView:
👉 Try it out
:hoversupport, the nesting indicator lines appear at all times.:hoversupport, the nesting indicator lines fade in when the user mouses over the entire component, or when there's focus inside the component. This makes sure the component remains simple when not in use.CleanShot.2022-09-19.at.16.56.18.mp4
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.