Uh oh!
There was an error while loading. Please reload this page.
fix(Button): only spread additional props onto StyledButton - #2359
Merged
Conversation
🦋 Changeset detectedLatest commit: b982e6a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
StyledButton
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#2351
This PR grabs the extra values from props in
ButtonBaseand spreads them ontoStyledButton.One thing I noticed is that the props for this custom component would not align with
ButtonPropsand so I created aCustomButtonPropstype to help out with this. I'd love feedback on if this would be the best way to support this, I wasn't quite sure what approach to take.Something else I noticed is that the custom component through
asmust acceptsxso I made sure the type intersects withSxProp.