Uh oh!
There was an error while loading. Please reload this page.
TreeView: Improve performance when rendering lots of items - #2460
Merged
Conversation
🦋 Changeset detectedLatest commit: 3d4566b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
colebemis
marked this pull request as ready for review
October 20, 2022 18:56
colebemis
requested review from
joshblack
and removed request for
josepmartinsOctober 20, 2022 19:21
colebemis
commented
Oct 20, 2022
ContributorAuthor
I'm going to wait for confirmation from @jdrush89 that this improves rendering performance in Repos. |
colebemis
commented
Oct 20, 2022
ContributorAuthor
That was all @siddharthkp 🙇 |
jdrush89
approved these changes
Oct 20, 2022
colebemis
commented
Oct 20, 2022
ContributorAuthor
@jdrush89 confirmed that these changes sped up the rendering performance of TreeView in dotcom ✅ 1000 directories now render in 833 ms (previously it was 3888 ms). 100 items render in ~90 ms (previously it was 1450 ms) |
Merged
josepmartins pushed a commit
that referenced
this pull request
Oct 21, 2022
* Avoid unecessary style recalculation * Add stress test story * Only render subtree if it's expanded * Don't expand current item by default * Update controlled story * Create popular-taxis-yawn.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR dramatically improves the rendering performance of TreeView. We accomplished this in two ways:
Stress test
TreeView with 1000 directories containing 100 files each:
Before
Page fails to load:
After
👉 Try it out
CleanShot.2022-10-20.at.11.47.04.mp4
Merge checklist
Added/updated documentationTake a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.