Uh oh!
There was an error while loading. Please reload this page.
feat(TreeView): add support for empty parent nodes - #2478
Merged
Conversation
🦋 Changeset detectedLatest commit: 19a9f0a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
joshblack
marked this pull request as ready for review
October 24, 2022 17:35
Contributor
size-limit report 📦
|
Uh oh!
There was an error while loading. Please reload this page.
colebemis
left a comment
Contributor
There was a problem hiding this comment.
Looks great! Could you add a couple of tests to make sure the aria-expanded attribute is behaving as expected in the sync and async cases?
colebemis
approved these changes
Oct 24, 2022
colebemis
left a comment
Contributor
There was a problem hiding this comment.
Thanks for tackling this tricky implementation 💖
Should be ready to merge after fixing the lint error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
TreeView.ItemandTreeView.SubTreebased on the feedback over in: https://github.com/github/primer/pull/1389#discussion_r998754809Changelog
New
EmptyDirectorystory forTreeViewChanged
TreeView.ItemandTreeView.SubTreeto coordinate whether or notaria-expandedshould be set in sync and async contextsTreeView.Itemto announce when aTreeView.SubTreehas no content when used in an async contextTreeView.Itemto shift conditional rendering ofTreeView.SubTreeintoTreeView.SubTreeTreeView.test.tsxto removeit.onlyand replace timers withjest.useFakeTimersRemoved