Uh oh!
There was an error while loading. Please reload this page.
fix(TreeView): add hcm styles for aria-current in TreeView - #2492
Merged
Conversation
🦋 Changeset detectedLatest commit: b154db4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
joshblack
commented
Oct 27, 2022
MemberAuthor
@ericwbailey would love your feedback on what the best values would be for HCM here. Mainly have just been using keywords from: https://www.w3.org/TR/css-color-4/#css-system-colors or transparent outlines. |
Contributor
size-limit report 📦
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the HCM feedback from: https://github.com/github/primer/issues/1114#issuecomment-1292865037
TreeView uses the
HighlightTextkeyword foraria-currentand focus stylesScreen.Recording.2022-10-31.at.3.38.13.PM.mov