Uh oh!
There was an error while loading. Please reload this page.
TreeView: Preserve expanded state of nested items - #2538
Merged
Conversation
🦋 Changeset detectedLatest commit: 2d19b1e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
colebemis
commented
Nov 7, 2022
Uh oh!
There was an error while loading. Please reload this page.
colebemis
commented
Nov 7, 2022
Uh oh!
There was an error while loading. Please reload this page.
…eact into treeview-persist-expanded-state
…t-expanded-state' of github.com:primer/react into treeview-persist-expanded-state
colebemis
marked this pull request as ready for review
November 8, 2022 04:55
colebemis
requested review from
a team, joshblack and siddharthkp
and removed request for
siddharthkpNovember 8, 2022 04:55
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Josh Black <joshblack@github.com>
joshblack
approved these changes
Nov 9, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested by @jsholes in his a11y sign-off review, this PR persists the expanded state of nested tree items when their parent is collapsed/expanded.
Before
CleanShot.2022-11-07.at.20.47.01.mp4
After
CleanShot.2022-11-07.at.20.47.48.mp4
Breaking changes
To implement this change, I had to introduce a required
idprop for all TreeView.Items.Merge checklist