Uh oh!
There was an error while loading. Please reload this page.
Update condensed mode for Safari workaround - #2569
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 8e714d9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
nicolleromeroforce-pushed
the
markdown-editor-resize-fix
branch
from
November 14, 2022 00:43
136faac to
737e8abComparejoshblack
approved these changes
Nov 15, 2022
nicolleromero
commented
Nov 15, 2022
ContributorAuthor
@joshblack Thanks for the review! Are there any additional steps I should take for this fix (regarding the changeset and merging)? |
joshblack
commented
Nov 16, 2022
Member
@nicolleromero just pushed one up! I think with this it should be good to go 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides a workaround for a bug in Safari that is preventing the
MarkdownEditorfrom resizing (due to not being recalculated) when rendered in thecondensedstate.This bug occurs after reopening the editor for the README a second (or subsequent) time and may be due to a bug introduced in version 15.5 of Safari. The bug is still present in Safari v16.0 and the proposed workaround does not affect behavior or rendering of the editor in Chrome or when not in
condensedmode.Fixeshttps://github.com/github/memex/issues/11141
Screenshots
*Both demos recorded in Safari v16.0 (also tested in Chrome)
BEFORE
MD.editor.resize.Safari.bug.mov
AFTER
MD.editor.resize.Safari.fix.mov
Non-condensed editor:
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.