Skip to content

Delete TreeView.LinkItem. - #2592

Merged
radglob merged 19 commits into
mainfrom
delete-treeview-linkitem
Nov 21, 2022
Merged

Delete TreeView.LinkItem.#2592
radglob merged 19 commits into
mainfrom
delete-treeview-linkitem

Conversation

@radglob

@radglobradglob commented Nov 17, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Removing the TreeView.LinkItem. It's a small extension of the TreeView.Item component, and would be unused if one is using a front-end router like react-router.

Screenshots

Please provide before/after screenshots for any visual changes

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@radglobradglob added the component: TreeView Issues related to the TreeView component label Nov 17, 2022
@radglobradglob self-assigned this Nov 17, 2022
@changeset-bot

changeset-botBot commented Nov 17, 2022•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 12beef7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@primer/reactPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@radglobradglob added the skip changeset This change does not need a changelog label Nov 17, 2022
@github-actions

github-actionsBot commented Nov 17, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
dist/browser.esm.js78.92 KB (0%)
dist/browser.umd.js79.55 KB (0%)

@github-actions
github-actionsBot temporarily deployed to storybook-preview-2592 November 17, 2022 17:06 Inactive
@radglob
radglob temporarily deployed to github-pages November 17, 2022 17:10 Inactive
@github-actions
github-actionsBot temporarily deployed to storybook-preview-2592 November 17, 2022 17:10 Inactive
@radglob
radglob temporarily deployed to github-pages November 17, 2022 17:20 Inactive
@github-actions
github-actionsBot temporarily deployed to storybook-preview-2592 November 17, 2022 17:21 Inactive
@github-actions
github-actionsBot temporarily deployed to storybook-preview-2592 November 17, 2022 17:35 Inactive
@radglob
radglob temporarily deployed to github-pages November 17, 2022 17:39 Inactive
@github-actions
github-actionsBot temporarily deployed to storybook-preview-2592 November 17, 2022 17:40 Inactive
@radglob
radglob marked this pull request as ready for review November 17, 2022 17:42
@radglob
radglob requested review from a team and colebemisNovember 17, 2022 17:42
colebemis
colebemis reviewed Nov 18, 2022
View reviewed changes

@colebemiscolebemis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for doing this, @radglob ✨

Left a minor comment about adding examples with onSelect to the docs.

You'll also need to add a changeset to this PR to describe the changes. I typically do that by clicking this link:

CleanShot 2022-11-18 at 09 31 50

Since this component is still in draft, we can call this a patch change

Comment threadCHANGELOG.md Outdated
Comment threaddocs/content/TreeView.mdx Outdated
@github-actions
github-actionsBot temporarily deployed to storybook-preview-2592 November 21, 2022 14:15 Inactive
@radglob
radglob temporarily deployed to github-pages November 21, 2022 14:17 Inactive
@github-actions
github-actionsBot temporarily deployed to storybook-preview-2592 November 21, 2022 14:17 Inactive
@github-actions
github-actionsBot temporarily deployed to storybook-preview-2592 November 21, 2022 14:17 Inactive
@github-actions
github-actionsBot temporarily deployed to storybook-preview-2592 November 21, 2022 15:06 Inactive
@radglob
radglob temporarily deployed to github-pages November 21, 2022 15:12 Inactive
@github-actions
github-actionsBot temporarily deployed to storybook-preview-2592 November 21, 2022 15:13 Inactive
colebemis
colebemis approved these changes Nov 21, 2022
View reviewed changes

@colebemiscolebemis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Nice work, @radglob! Just left a small suggestion about the release notes. Feel free to merge this after you've addressed my comment.

Comment thread.changeset/honest-moles-divide.md Outdated
@radglob@colebemis
Update .changeset/honest-moles-divide.md
12beef7
Co-authored-by: Cole Bemis <colebemis@github.com>
@radglob
radglob enabled auto-merge (squash) November 21, 2022 21:17
@radglob
radglob temporarily deployed to github-pages November 21, 2022 21:23 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-2592 November 21, 2022 21:23 Inactive
@radglob
radglob merged commit d9c7290 into mainNov 21, 2022
@radglob
radglob deleted the delete-treeview-linkitem branch November 21, 2022 21:24
@primer-cssprimer-css mentioned this pull request Nov 21, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@colebemiscolebemiscolebemis approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@radglobradglob

Labels

component: TreeViewIssues related to the TreeView componentskip changesetThis change does not need a changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@radglob@colebemis