Uh oh!
There was an error while loading. Please reload this page.
UnderlineNav2: Accessibility remediations (Take out of JS template literals) - #2603
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: b0f0fa4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
broccolinisoupforce-pushed
the
UnderlineNav-sign-off-review-final-impr
branch
from
November 22, 2022 06:36
201eb86 to
b0f0fa4Compare Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue came from accessibility sign-off review.
The Problem
It turns out, when non-breaking spaces are rendered within JS template literals, they are not treated as escaped characters in HTML.
The Solution
I took the non-breaking spaces out of the template literals and it seems that resolved the issue.
And MacOS VoiceOver announces the spacing properly.
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.