Uh oh!
There was an error while loading. Please reload this page.
CounterLabel: Accessibility improvements for better screen reader announcing - #2604
Merged
Conversation
🦋 Changeset detectedLatest commit: d6259ba The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
broccolinisoupforce-pushed
the
counter-label-a11y-counters
branch
from
November 22, 2022 06:24
50d3298 to
7f010f6Comparebroccolinisoup
marked this pull request as draft
November 22, 2022 06:42
broccolinisoup
marked this pull request as ready for review
November 22, 2022 08:45
broccolinisoupforce-pushed
the
counter-label-a11y-counters
branch
from
November 24, 2022 03:32
1d16e36 to
a38e0afCompare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closeshttps://github.com/github/primer/issues/1507
This PR brings improvement on the CounterLabel to make the counter data have an accessible name.
styled-componentsstyled-componentsspecific implementation detailsaria-hidden=trueto the existing span (visual representation of the counter)Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.