Uh oh!
There was an error while loading. Please reload this page.
refactor(project): update TypeScript definitions for React 18 - #2664
Merged
Conversation
🦋 Changeset detectedLatest commit: 9b87ecd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
joshblack
commented
Dec 7, 2022
MemberAuthor
@siddharthkp would love your feedback on how to make Slots work with generic children if you have a sec! I feel like the changes I made to get it working are not really correct and we would need to make the context itself generic, potentially. |
Contributor
size-limit report 📦
|
joshblack
temporarily deployed
to
github-pages
December 7, 2022 20:02 — with 
GitHub Actions
Inactive
joshblack
temporarily deployed
to
github-pages
December 8, 2022 22:57 — with GitHub Actions
Inactive
joshblack
temporarily deployed
to
github-pages
December 9, 2022 19:58 — with GitHub Actions
Inactive
colebemis
approved these changes
Dec 13, 2022
22 tasks
This reverts commit c5778d8.
joshblack
temporarily deployed
to
github-pages
December 15, 2022 18:29 — with GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update TypeScript types for React 18. The goal for this is to support both React 18 and React 17 types.
Some of the changes included:
useCallbackneeded the arguments to be typedVFCis deprecated in React 18childrenprop (likereact-dnd)