Uh oh!
There was an error while loading. Please reload this page.
Setting overflow: auto without a media query to fix resizable pane bug. - #2685
Conversation
🦋 Changeset detectedLatest commit: 26d2501 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
Uh oh!
There was an error while loading. Please reload this page.
While we're here, can we add any tests to avoid regressing the resizable pane again in the future? |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
1e1eb12 to
a251e0eCompare| fireEvent.mouseDown(divider) | ||
| fireEvent.mouseMove(divider) | ||
| fireEvent.mouseUp(divider) |
There was a problem hiding this comment.
This isn't a perfect test. I'm not sure how to configure this to move the divider a specific amount. However, as is, this does change the --pane-width value. fireEvent.click doesn't do that, so I think this is testing what we want.
Co-authored-by: Cole Bemis <colebemis@github.com>
This basically reverts the work in #2606. Setting
overflow: autoinside of a media query seemed to fix an issue where scrolling panes would be hard to use on mobile as you would have a scrolling container within another scrolling container. Changing this back to not use a media query seems to have the desired behavior without breaking resizable panes.Closes#2684.
Screenshots
Please provide before/after screenshots for any visual changes
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.