Uh oh!
There was an error while loading. Please reload this page.
1518 react treeview feedback from screen reader - #2710
Conversation
Co-authored-by: Josh Black <joshblack@users.noreply.github.com>
…eedback-from-screen-reader
🦋 Changeset detectedLatest commit: 84825f0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
colebemis
commented
Dec 19, 2022
Could you expand on this? What do you think the root cause of this issue is? |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Cole Bemis <colebemis@github.com>
Co-authored-by: Cole Bemis <colebemis@github.com>
…eedback-from-screen-reader
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
colebemis
left a comment
There was a problem hiding this comment.
Thanks for walking me through these changes, @green6erry! Looks good to me. Just left a small suggestion about adding a code comment to explain isPending.
7f02e48 to
e22e310CompareCo-authored-by: Cole Bemis <colebemis@github.com>
Describe your changes here.
Closes1518 as somewhat of a bandaid for the issue. The reason this is happening is from a larger issue with the api. For now, the aria message is now updating the status correctly based on which branch is expanded.
Screenshots
Please provide before/after screenshots for any visual changes

Before:
Directory with async itemsis expanded, but the status reads that that the last child,Nested Directoryis empty. This is both not true, and irrelevant to expandingDirectory with async itemsAfter:

Now when
Directory with async itemsis expanded, the status accurately reads that it has loaded.Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.