Uh oh!
There was an error while loading. Please reload this page.
Reimplemented tooltips using the Popover API. - #2804
Closed
radglob wants to merge 48 commits into
Closed
Conversation
🦋 Changeset detectedLatest commit: 505dbc5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
radglob
marked this pull request as ready for review
January 25, 2023 20:28
radglob
commented
Jan 26, 2023
ContributorAuthor
This is going to be held up for the moment. There's a conflict in transitive dependencies (specifically some packages that storybook uses) that can't be updated without bumping a major version on Storybook. |
Contributor
size-limit report 📦
|
Contributor
Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reimplemented the Tooltip component using the Popover API. This should not change anything about the tooltip component from a user's perspective.
Bring this in line with the PVC implementation, this doesn't support the
alignprop. Users should use the diagonal directions for this instead.Since the Popover API is not yet available in stable browsers, this includes a polyfill as well as an update to
styled-componentsfrom 4.x to 5.x to take advantage of the shouldForwardProp feature. That update will block merging to main, since we would need to update all dependent applications to use 5.x. Primer currently supports either 4.x or 5.x.Closes#2124.
Screenshots
Please provide before/after screenshots for any visual changes
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.