Skip to content

feat(Button): add default type#2807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshblack merged 4 commits into from
Jan 26, 2023
Merged

feat(Button): add default type #2807

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
25e3640
feat(Button): add default type
joshblack Jan 24, 2023
3cf42e6
Create .changeset/chilly-knives-impress.md
joshblack Jan 24, 2023
4f76ea1
test: update snapshots
joshblack Jan 26, 2023
a5be8b0
Merge branch 'main' into joshblack-patch-1
joshblack Jan 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/chilly-knives-impress.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@primer/react": minor
---

Add default `type="button"` for `Button`. This removes the implicit `type="submit"` for a `<button>` and requires an explicit `type` to change.
2 changes: 1 addition & 1 deletion src/Button/Button.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,7 @@ import {ForwardRefComponent as PolymorphicForwardRefComponent} from '../utils/po

const ButtonComponent = forwardRef(({children, ...props}, forwardedRef): JSX.Element => {
return (
<ButtonBase ref={forwardedRef} as="button" {...props}>
<ButtonBase ref={forwardedRef} as="button" type="button" {...props}>
{children}
</ButtonBase>
)
Expand Down
5 changes: 5 additions & 0 deletions src/__tests__/__snapshots__/Button.test.tsx.snap
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -104,6 +104,7 @@ exports[`Button renders consistently 1`] = `

<button
className="c0"
type="button"
/>
`;

Expand DownExpand Up@@ -227,6 +228,7 @@ exports[`Button styles danger button appropriately 1`] = `

<button
class="c0"
type="button"
>
<span
data-component="text"
Expand DownExpand Up@@ -451,6 +453,7 @@ exports[`Button styles invisible button appropriately 1`] = `

<button
class="c0"
type="button"
>
<span
data-component="text"
Expand DownExpand Up@@ -581,6 +584,7 @@ exports[`Button styles outline button appropriately 1`] = `

<button
class="c0"
type="button"
>
<span
data-component="text"
Expand DownExpand Up@@ -706,6 +710,7 @@ exports[`Button styles primary button appropriately 1`] = `

<button
class="c0"
type="button"
>
<span
data-component="text"
Expand Down