Uh oh!
There was an error while loading. Please reload this page.
feat(DataTable): add support for title and subtitle - #2839
Conversation
|
size-limit report 📦
|
ericwbailey
left a comment
There was a problem hiding this comment.
I am not a TypeScript expert, but this looks good from my perspective.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
colebemis
left a comment
There was a problem hiding this comment.
Looks good! Just left a couple comments about using design tokens
Co-authored-by: Cole Bemis <colebemis@github.com>
Co-authored-by: Cole Bemis <colebemis@github.com>
4130994 to
c921bd8Compare
Add support for title and subtitle for
DataTablebased on: https://github.com/github/primer/pull/1712This PR adds in
TableContainer,TableTitle, andTableSubtitlealong with documentation to link the title and subtitle to a table. This work does not include support for table actions.This work differs from the API doc in that
TableContaineris being used for the overall container where-as I believeDataTablewas the containing element in the proposal. Currently,DataTableis used to represent the table itself. Naming seems to be something we can address outside of this PR, instead this is meant to:Changelog
New
TableContainercomponent for laying out the tableTableTitlecomponent for providing a table titleTableSubtitlecomponent for providing a table descriptionDataTableChanged
TableTitleandTableSubtitlefor labeling and describing aTableDataTableto includeTableContainer,TableTitle, andTableSubtitleRemoved