Uh oh!
There was an error while loading. Please reload this page.
Button API alignment - #2893
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: de3dc1c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…er/react into button-api-breaking-changes
langermank
commented
Feb 10, 2023
ContributorAuthor
If someone wants to pair with me on how to add a codemod to handle all these prop changes, that would be great! |
langermank
temporarily deployed
to
github-pages
February 10, 2023 22:27 — with 
GitHub Actions
Inactive
langermank
temporarily deployed
to
github-pages
February 10, 2023 23:13 — with GitHub Actions
Inactive
broccolinisoup
temporarily deployed
to
github-pages
February 16, 2023 23:45 — with GitHub Actions
Inactive
Contributor
size-limit report 📦
|
broccolinisoup
temporarily deployed
to
github-pages
February 17, 2023 00:02 — with GitHub Actions
Inactive
broccolinisoup
temporarily deployed
to
github-pages
February 17, 2023 04:02 — with GitHub Actions
Inactive
broccolinisoup
temporarily deployed
to
github-pages
June 6, 2023 09:45 — with GitHub Actions
Inactive
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes breaking changes to bring the PRC Button up to the agreed upon API spec and match implementation with PVC.
leadingIconandtrailingIcontoleadingVisualandtrailingVisual(a pattern introduced with ActionList)Button.Counteras a child component, replacing it with acountprop. This change allows us to use thetrailingVisualslot for counters, and also aligns better with all the other child elements within Button (visuals are props, not child components in this case.)outlinebutton variant as we wish to only supportinvisiblebuttons.Screenshots
The only visual change is that the
outlinebutton variant has been removed.Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.