Uh oh!
There was an error while loading. Please reload this page.
PageHeader: A11y eng review remediations - #2900
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 2347578 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
broccolinisoup
temporarily deployed
to
github-pages
February 13, 2023 05:59 — with 
GitHub Actions
Inactive
broccolinisoupforce-pushed
the
a11y-page-header
branch
from
February 13, 2023 06:40
a42d63a to
3b315c1Comparebroccolinisoup
temporarily deployed
to
github-pages
February 13, 2023 06:46 — with GitHub Actions
Inactive
broccolinisoup
temporarily deployed
to
github-pages
February 13, 2023 06:54 — with GitHub Actions
Inactive
broccolinisoup
temporarily deployed
to
github-pages
February 13, 2023 08:00 — with GitHub Actions
Inactive
TylerJDev
approved these changes
Feb 13, 2023
TylerJDev
left a comment
Member
There was a problem hiding this comment.
Looks great! Love the additional tests added too. 🎉
joshblack
requested changes
Feb 14, 2023
joshblack
left a comment
Member
There was a problem hiding this comment.
Left a comment for wrapping the warning in a __DEV__ check, should be good to go after that!
Uh oh!
There was an error while loading. Please reload this page.
broccolinisoup
temporarily deployed
to
github-pages
February 15, 2023 05:26 — with GitHub Actions
Inactive
joshblack
approved these changes
Feb 15, 2023
broccolinisoup
temporarily deployed
to
github-pages
February 15, 2023 23:34 — with GitHub Actions
Inactive
broccolinisoup
temporarily deployed
to
github-pages
February 16, 2023 04:37 — with GitHub Actions
Inactive
broccolinisoup
temporarily deployed
to
github-pages
February 16, 2023 05:31 — with GitHub Actions
Inactive
github-merge-queueBot
removed this pull request from the merge queue due to failed status checks
Feb 16, 2023
Uh oh!
There was an error while loading. Please reload this page.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes here.
This PR addresses issues found and implement recommendations from
PageHeaderaccessibility eng review . Please see this comment for more info on each item below.Issues addressed:
aria-labelonParentLinkcomponent.Recommendations implemented:
as=”nav | div”onPageHeader.Navigationcomponent.Also Added a feature story to cover custom components that can be passed to
PageHeader.Navigationas childrenScreenshots
No visual changes.
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.