Uh oh!
There was an error while loading. Please reload this page.
Tooltip: Update the component markup for a11y remediations & refactor the existing styles towards more static styling - #3032
Conversation
🦋 Changeset detectedLatest commit: 7a816fb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
broccolinisoup
commented
Apr 5, 2023
Note that the snapshots are failing on main. It should be good once we resolve the issue on main |
TylerJDev
left a comment
There was a problem hiding this comment.
Amazing work @broccolinisoup! 🤩
This tooltip will be a huge improvement over our current one in terms of accessibility. As far as my comments, you've addressed all of them! Thanks so much for all the work on this! 🎉
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
cdddec8 to
a694fbcCompare
Closeshttps://github.com/github/primer/issues/1909
Closeshttps://github.com/github/primer/issues/1907
Closeshttps://github.com/github/primer/issues/1918
Storybook features: https://primer-7bad896c1f-13348165.drafts.github.io/storybook/?path=/story/components-tooltip-features--tooltip-description-type-tooltip
Docs: https://primer-7bad896c1f-13348165.drafts.github.io/Tooltip
This PR refactors the current
Tooltipcomponent to update the markup and styles to match with the expected accessibility requirements.Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.