Uh oh!
There was an error while loading. Please reload this page.
feat(DataTable): add Table.Skeleton - #3055
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 0ebec96 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
…o feat/add-table-skeleton
joshblack
marked this pull request as ready for review
March 22, 2023 20:37
joshblack
requested review from
a team, JoshBowdenConcepts, colebemis and mperrotti
and removed request for
JoshBowdenConceptsMarch 22, 2023 20:37
colebemis
approved these changes
Mar 22, 2023
colebemis
left a comment
Contributor
There was a problem hiding this comment.
Looks great! 🚀
- Verify that the "With Loading" example is available on the storybook and included in the docs.json for DataTable
- Verify that the styles look as expected for the Table Skeleton
- Verify that Table.Skeleton is defined and its props are exported
- Verify that a test exists for rendering a Table.Skeleton
joshblack
commented
Mar 24, 2023
MemberAuthor
bump @mperrotti when you have a sec to review! |
mperrotti
approved these changes
Mar 31, 2023
mperrotti
left a comment
Contributor
There was a problem hiding this comment.
I'm so sorry I didn't review this sooner! I have no idea how it slipped by me.
| flex-direction: column; | ||
| } | ||
| .TableCellSkeletonItem { |
Contributor
There was a problem hiding this comment.
If we see this style of "loading" placeholder come up again, we should consider creating some kind of "SkeletonLoader" component that can be reused. We already use something identical in TreeView.
This was referenced Apr 3, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch: https://github.com/github/primer/issues/1892
This is currently a visual an API implementation of
Table.Skeleton. The behavior is not finalized when it comes to how to indicate loading content. In the meantime, the cells themselves contain "Loading" as text content. Most of the styles for the Table cell skeleton items are lifted from TreeView.One caveat to this API, it is currently bound to
Columnas it seemed natural to toggle between the two with an existing set ofcolumns. It may be useful in the future to permit less restrictive types (likeArray<string>) for usage.Testing & Reviewing
Table.Skeletonis defined and its props are exportedTable.Skeletonrowssince it's a visual only change and I did not want to test structural changes in enzyme